feat(contacts): support federated users/groups search when adding team members

[cristianscheid]

• Related to: 33: federated account from contacts app circles#2303

Summary

Adds possibility to search for federated users (accounts from other instances) and federated groups when adding members to a team in the Contacts app.

Context

• This PR implements the backend portion. Frontend implementation: feat(teams): support federated users/groups search when adding team members contacts#5037.

When searching for members to add to a team in the Contacts app, a GET request is made to ocs/v2.php/apps/files_sharing/api/v1/sharees which in turn calls files_sharing/lib/Controller/ShareesAPIController::search().

This is the same endpoint used by the Files app when searching to add an external share (used as a reference here, as pointed out in the issue).

Changes

• Modified files_sharing/lib/Controller/ShareesAPIController::search() to handle contacts itemType, allowing TYPE_REMOTE and TYPE_REMOTE_GROUP searches
• Injected FederatedShareProvider into the controller constructor to check federation settings
• Called federation check methods directly via FederatedShareProvider
  • The wrapper methods isRemoteSharingAllowed() and isRemoteGroupSharingAllowed() require a share backend implementation
  • They call isShareTypeAllowed(), which ultimately invokes the same FederatedShareProvider methods used in this implementation (isOutgoingServer2serverShareEnabled() and isOutgoingServer2serverGroupShareEnabled())
  • Since contacts doesn't have a registered share backend (similar to calendar), this direct approach was taken to achieve same functionality

Note

When testing locally, the federated search functionality works correctly (remote users appear in search results). However, when attempting to actually add the remote member to a team, an error occurs indicating the remote instance is unreachable. I believe this is expected behavior when running locally, as a similar error occurs when trying to add an external share in the Files app using the same remote account, which is the reference implementation mentioned in the issue and was not modified in this PR.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[cristianscheid]

/backport to stable33

Missing test changes

[salmart-dev]

I think tests need to be adapted with the new changes, the ShareesAPIController tests are failing because of the extra constructor parameter

[come-nc]

There is no documentation whatsoever about what’s accepted as an $itemType and that’s triggering me.
But not the subject of that PR I suppose.

I’m not sure why TYPE_EMAIL is added to $shareTypes in this new if branch, but is it seems a copypaste from the else with only remote added I guess it makes sense.

[cristianscheid]

I think tests need to be adapted with the new changes, the ShareesAPIController tests are failing because of the extra constructor parameter

@salmart-dev thanks for the input! I'll look into it.

I’m not sure why TYPE_EMAIL is added to $shareTypes in this new if branch, but is it seems a copypaste from the else with only remote added I guess it makes sense.

@come-nc thanks for the review! Yes, basically the ideia was to keep the original functionallity (inside else) and add remote support, avoiding breaking or removing existing behavior and only introducing a new addition.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)