Skip to content

fix(theming): display error messages on image upload and delete previous image only after validation#58003

Merged
susnux merged 5 commits intomasterfrom
fix/57669/show-theming-image-upload-errors
Feb 13, 2026
Merged

fix(theming): display error messages on image upload and delete previous image only after validation#58003
susnux merged 5 commits intomasterfrom
fix/57669/show-theming-image-upload-errors

Conversation

@cristianscheid
Copy link
Contributor

Summary

Display error feedback to users when image upload fails in the theming admin section.

Changes

  • Add error handling on frontend to show server messages for 422 errors and generic messages for other status codes
  • Validate new image before deleting the previous one to preserve valid images when upload fails

Screenshots

01 02

Checklist

@cristianscheid cristianscheid self-assigned this Feb 2, 2026
@cristianscheid cristianscheid requested review from a team as code owners February 2, 2026 17:24
@cristianscheid cristianscheid removed the request for review from a team February 2, 2026 17:24
@cristianscheid cristianscheid requested review from leftybournes and removed request for a team February 2, 2026 17:24
@cristianscheid
Copy link
Contributor Author

/backport to stable33

@cristianscheid
Copy link
Contributor Author

/backport to stable32

@cristianscheid
Copy link
Contributor Author

/backport to stable31

@nextcloud-command nextcloud-command force-pushed the fix/57669/show-theming-image-upload-errors branch from 1fc10b9 to fd7a859 Compare February 3, 2026 18:32
@cristianscheid cristianscheid requested a review from susnux February 3, 2026 18:36
@cristianscheid
Copy link
Contributor Author

/compile rebase

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

cristianscheid and others added 3 commits February 12, 2026 08:03
…ous image only after validation

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid force-pushed the fix/57669/show-theming-image-upload-errors branch from fd7a859 to 7ab1c0f Compare February 12, 2026 11:46
Signed-off-by: Cristian Scheid <74515775+cristianscheid@users.noreply.github.com>
@cristianscheid
Copy link
Contributor Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit fee431f into master Feb 13, 2026
177 of 179 checks passed
@susnux susnux deleted the fix/57669/show-theming-image-upload-errors branch February 13, 2026 10:49
@backportbot
Copy link

backportbot bot commented Feb 13, 2026

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/58003/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0a5f75e7 347c5093 7ab1c0f2 0f91aec1

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58003/stable31

Error: Failed to push branch backport/58003/stable31: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@cristianscheid
Copy link
Contributor Author

The backport to stable31 failed. Please do this backport manually.

Since v31 is no longer among the currently supported versions, I will not proceed with this backport request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing error handling for invalid theming image upload

5 participants