fix(files): Prevent file list from jumping when selecting visible files#58087
Merged
fix(files): Prevent file list from jumping when selecting visible files#58087
Conversation
nfebe
requested review from
CarlSchwan,
sorbaugh,
susnux and
szaimen
and removed request for
a team
susnux
reviewed
Feb 5, 2026
nfebe
force-pushed
the
fix/54700/file-list-scroll-jump
branch
from
5c5ae62 to
4da404c
Compare
susnux
reviewed
Feb 5, 2026
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Logic seems fine, just not sure why we need the outer if here
nfebe
force-pushed
the
fix/54700/file-list-scroll-jump
branch
2 times, most recently
from
0563bcb to
61a5625
Compare
susnux
approved these changes
Feb 5, 2026
nfebe
force-pushed
the
fix/54700/file-list-scroll-jump
branch
from
61a5625 to
a6991ca
Compare
Contributor
Author
|
/compile |
cristianscheid
approved these changes
Feb 5, 2026
nfebe
force-pushed
the
fix/54700/file-list-scroll-jump
branch
from
ada68f0 to
221970c
Compare
Contributor
Author
|
/compile |
Skip scrolling when a file is clicked if it's already within the visible viewport, avoiding the confusing list jump behavior. Fixes #54700 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Adjust test assertions to match the new behavior where scrolling is skipped for files already in the visible buffer. Tests now verify file existence rather than full visibility for files within the buffer. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/54700/file-list-scroll-jump
branch
from
7e3fc0e to
b0bf531
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Contributor
Author
|
/backport to stable33 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip scrolling when a file is clicked if it's already within the visible viewport, avoiding the confusing list jump behavior.
Fixes #54700