Skip to content

[stable33] fix(files): improve handling of copy-move action#58129

Merged
AndyScherzinger merged 2 commits intostable33from
backport/57993/stable33
Feb 6, 2026
Merged

[stable33] fix(files): improve handling of copy-move action#58129
AndyScherzinger merged 2 commits intostable33from
backport/57993/stable33

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 6, 2026

Backport of #57993

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Feb 6, 2026
@backportbot backportbot bot added this to the Nextcloud 33 milestone Feb 6, 2026
@susnux susnux force-pushed the backport/57993/stable33 branch from c9437e0 to 586942e Compare February 6, 2026 11:46
@susnux susnux marked this pull request as ready for review February 6, 2026 11:47
@susnux susnux requested review from a team and skjnldsv as code owners February 6, 2026 11:47
@susnux
Copy link
Contributor

susnux commented Feb 6, 2026

/compile

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

1. only show 1 loading toast instead of N for N files in batch
   operation.
2. Reuse more code to reduce duplicated logic.
3. Show the conflict picker once for all files instead of opening a new
   conflict picker for every file to copy / move.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/57993/stable33 branch from 1a669e2 to ca0ac59 Compare February 6, 2026 11:59
@AndyScherzinger AndyScherzinger merged commit 8058da3 into stable33 Feb 6, 2026
134 of 137 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/57993/stable33 branch February 6, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants