Skip to content

fix(user_status): use getFirstDay() from @nextcloud/l10n#58218

Merged
Antreesy merged 2 commits intomasterfrom
fix/57804/clear-status-this-week
Feb 10, 2026
Merged

fix(user_status): use getFirstDay() from @nextcloud/l10n#58218
Antreesy merged 2 commits intomasterfrom
fix/57804/clear-status-this-week

Conversation

@cristianscheid
Copy link
Contributor

Summary

Fixes silent failure when setting "Clear status after: This week" from the status menu.

Changes

  • Fixed TypeError by importing and using getFirstDay() from @nextcloud/l10n instead of calling the non-existent endOfWeek.getFirstDay() method on a Date object

Screenshots

demo.webm

Checklist

@cristianscheid cristianscheid self-assigned this Feb 10, 2026
@cristianscheid cristianscheid requested a review from a team as a code owner February 10, 2026 11:40
@cristianscheid cristianscheid requested review from nfebe, sorbaugh and szaimen and removed request for a team February 10, 2026 11:40
@cristianscheid
Copy link
Contributor Author

/backport to stable33

@cristianscheid
Copy link
Contributor Author

/compile rebase

@nextcloud-command nextcloud-command force-pushed the fix/57804/clear-status-this-week branch from 83a7598 to 064bc36 Compare February 10, 2026 12:31
@nickvergessen nickvergessen added this to the Nextcloud 34 milestone Feb 10, 2026
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think something's messed up with the compiled assets, I'll check and rebase after second review, if needed

@nextcloud nextcloud deleted a comment from cristianscheid Feb 10, 2026
@nextcloud nextcloud deleted a comment from cristianscheid Feb 10, 2026
@Antreesy
Copy link
Contributor

Checked stable32 and stable31, there's still moment library used, so there's no silent error as on master. I removed the backport requests for those.

Although it gets the last day from user setting of 'locale', not user setting of 'first day of the week'. Should be adjusted separately for older branches, if needed

@Antreesy Antreesy requested a review from susnux February 10, 2026 13:12
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@Antreesy Antreesy force-pushed the fix/57804/clear-status-this-week branch from 064bc36 to 2ddf73f Compare February 10, 2026 15:28
@Antreesy
Copy link
Contributor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Antreesy Antreesy merged commit a096c89 into master Feb 10, 2026
126 checks passed
@Antreesy Antreesy deleted the fix/57804/clear-status-this-week branch February 10, 2026 15:56
@backportbot
Copy link

backportbot bot commented Feb 10, 2026

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/58218/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2ddf73f8 65632142

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58218/stable33

Error: Failed to push branch backport/58218/stable33: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor

susnux commented Feb 10, 2026

/backport to stable33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Clear status after "This week" results in "There was an error saving the status"

5 participants