fix(user_status): use getFirstDay() from @nextcloud/l10n#58218
fix(user_status): use getFirstDay() from @nextcloud/l10n#58218
Conversation
|
/backport to stable33 |
|
/compile rebase |
83a7598 to
064bc36
Compare
Antreesy
left a comment
There was a problem hiding this comment.
Thanks!
I think something's messed up with the compiled assets, I'll check and rebase after second review, if needed
|
Checked Although it gets the last day from user setting of 'locale', not user setting of 'first day of the week'. Should be adjusted separately for older branches, if needed |
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
064bc36 to
2ddf73f
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/58218/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2ddf73f8 65632142
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58218/stable33Error: Failed to push branch backport/58218/stable33: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable33 |
Summary
Fixes silent failure when setting "Clear status after: This week" from the status menu.
Changes
getFirstDay()from@nextcloud/l10ninstead of calling the non-existentendOfWeek.getFirstDay()method on a Date objectScreenshots
demo.webm
Checklist
3. to review, feature component)stable32)