fix(setup): prevent unnecessary mime migrations on new installs#58235
Open
joshtrichards wants to merge 2 commits intomasterfrom
Open
fix(setup): prevent unnecessary mime migrations on new installs#58235joshtrichards wants to merge 2 commits intomasterfrom
joshtrichards wants to merge 2 commits intomasterfrom
Conversation
Avoids running the repairs for prior versions (that are otherwise a no-op) and also avoids the misleading/confusing setup check warning on new installations about "One oe more mimetype migrations are available [...]". Signed-off-by: Josh <josh.t.richards@gmail.com>
- fix: Makes it impossible to accidentally skip pre-v29 mime repair steps even if one has skipped them up past v29. With the old behavior, when triggering mime type repair steps in an environment that's been upgraded from pre-v29 w/o running some steps, it was possible to never be able to run the earlier skipped steps. This change makes things consistent and clean. - cleanup: Drops no longer needed 29.0.0.10 version check Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
joshtrichards
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)