fix(setup): add index properties_name_path_user by default on new installs#58236
Open
joshtrichards wants to merge 1 commit intomasterfrom
Open
fix(setup): add index properties_name_path_user by default on new installs#58236joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
Added in #52175 but only to the missing indices listener. Resulted in new installations trigger warnings about database missing indices unnecessary. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
leftybournes and
salmart-dev
and removed request for
a team
5 tasks
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
joshtrichards
changed the title
joshtrichards
changed the title
CarlSchwan
reviewed
Feb 11, 2026
| // $table->addIndex(['userid'], 'property_index'); | ||
| $table->addIndex(['userid', 'propertypath'], 'properties_path_index'); | ||
| $table->addIndex(['propertypath'], 'properties_pathonly_index'); | ||
| $table->addIndex(['propertyname', 'propertypath', 'userid'], 'properties_name_path_user'); |
Member
There was a problem hiding this comment.
we need a coresponding AddMissingIndicesEvent listener so that occ db:add-missing-indices works too
Member
Author
There was a problem hiding this comment.
There is one already in #52175. :-) That's all there is though. This PR makes sure it's also created initially on new installs (rather than waiting for someone to trigger the listener).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added in #52175 but only to the missing indices listener. Resulted in new installations having warnings about database missing indices unnecessarily.
TODO
Checklist
3. to review, feature component)stable32)