Skip to content

[stable32] fix(theming): display error messages on image upload and delete previous image only after validation #58322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backportbot wants to merge 2 commits into
base: stable32
Choose a base branch
from
+2 −2
Open

[stable32] fix(theming): display error messages on image upload and delete previous image only after validation #58322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a4b80c
fix(theming): display error messages on image upload and delete previ…
cristianscheid Feb 2, 2026
363e6b2
refactor(theming): use isAxiosError for error handling
cristianscheid Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/theming/lib/ImageManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,6 @@ public function delete(string $key): void {
}

public function updateImage(string $key, string $tmpFile): string {
$this->delete($key);

try {
$folder = $this->getRootFolder()->getFolder('images');
} catch (NotFoundException $e) {
Expand All @@ -217,6 +215,8 @@ public function updateImage(string $key, string $tmpFile): string {
throw new \Exception('Unsupported image type: ' . $detectedMimeType);
}

$this->delete($key);

if ($key === 'background') {
if ($this->shouldOptimizeBackgroundImage($detectedMimeType, filesize($tmpFile))) {
try {
Expand Down
Loading