dont set the mimetype on public video previews #605
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Henni, @LukasReschke and @schiessle to be potential reviewers |
Member
|
That is super weird. Could you try to report this upstream? |
Member
|
👎 This really is an issue we should solve differently. |
Member
Any idea how? |
MorrisJobke
added
1. to develop
Member
|
I have no clue but not setting the mimetype is just weird. Then we can just drop the mimetype since there will always be a browser with obscure behaviour. |
Member
|
I will close this ticket here and opened #763 to track this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome(ium) refuses to play mkv files if it know's it's an mkv video.
If you don't tell chrome it's an mkv it will play the file without complaints (assuming you have the codecs of course)
Not setting the type doesn't seem to have any negative effect from what I can tell with a bit of testing in chrome and ff