Skip to content

Conversation

@jancborchardt
Copy link
Member

Just a tiny detail I noticed about the new datepicker, that the 3px border-radius was missing. Ref #5713

Easy fix, please review @pixelipo @nextcloud/designers :)

screenshot from 2017-08-25 14-06-02screenshot from 2017-08-25 14-07-44

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added 3. to review Waiting for reviews design Design, UI, UX, etc. enhancement labels Aug 25, 2017
@jancborchardt jancborchardt added this to the Nextcloud 13 milestone Aug 25, 2017
@jancborchardt
Copy link
Member Author

Also btw @pixelipo is there a specific reason we don’t show the days of the month previous/after in the popover, like we do in Deck?

Copy link
Contributor

@pixelipo pixelipo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pixelipo
Copy link
Contributor

@jancborchardt that's a datepicker setting with each app having their own set. For some reason Files devs decided to hide those. I haven't made any changes there.

@rullzer rullzer merged commit 1682ead into master Aug 25, 2017
@rullzer rullzer deleted the popover-border-radius branch August 25, 2017 13:58
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants