Skip to content

Conversation

@juliusknorr
Copy link
Member

Follow up of #6341 fixes #4264

cc @newhinton

@mention-bot
Copy link

@juliushaertl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @LukasReschke and @nickvergessen to be potential reviewers.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov
Copy link

codecov bot commented Sep 2, 2017

Codecov Report

Merging #6342 into master will decrease coverage by 16.33%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #6342       +/-   ##
=============================================
- Coverage     53.31%   36.97%   -16.34%     
  Complexity    22497    22497               
=============================================
  Files          1403     1403               
  Lines         87079    87087        +8     
  Branches       1327     1327               
=============================================
- Hits          46422    32197    -14225     
- Misses        40657    54890    +14233
Impacted Files Coverage Δ Complexity Δ
core/Controller/LoginController.php 0% <0%> (-77.28%) 38 <0> (ø)
...mments/tests/Unit/Controller/NotificationsTest.php 0% <0%> (-100%) 4% <0%> (ø)
.../Exceptions/EncryptionHeaderKeyExistsException.php 0% <0%> (-100%) 1% <0%> (ø)
apps/files/lib/Activity/Settings/FileFavorite.php 0% <0%> (-100%) 8% <0%> (ø)
apps/files/lib/Activity/Settings/FileRestored.php 0% <0%> (-100%) 8% <0%> (ø)
lib/private/Template/ResourceNotFoundException.php 0% <0%> (-100%) 2% <0%> (ø)
...ib/private/Contacts/ContactsMenu/ActionFactory.php 0% <0%> (-100%) 2% <0%> (ø)
apps/federation/lib/Hooks.php 0% <0%> (-100%) 4% <0%> (ø)
...curity/Exceptions/StrictCookieMissingException.php 0% <0%> (-100%) 1% <0%> (ø)
...te/Authentication/Token/DefaultTokenCleanupJob.php 0% <0%> (-100%) 1% <0%> (ø)
... and 479 more

@MorrisJobke MorrisJobke requested a review from rullzer September 3, 2017 16:53
@rullzer rullzer merged commit 57b74c9 into master Sep 4, 2017
@rullzer rullzer deleted the rich-link-preview branch September 4, 2017 10:02
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Sep 4, 2017
@MorrisJobke
Copy link
Member

Broken unit tests fixed in 0326c2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rich Link Preview Extension

5 participants