Skip to content

Use the language of the recipient for the share notification #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Sep 8, 2017
Merged

Use the language of the recipient for the share notification #6414

MorrisJobke merged 1 commit into from
Sep 8, 2017

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 8, 2017

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Sep 8, 2017
@nickvergessen
Use the language of the recipient for the share notification
7e625a8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the share-notification-wrong-language branch from e416e71 to 7e625a8 Compare September 8, 2017 08:48
blizzz
blizzz approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (cannot test because SwiftMailer is acting up entry in hosts fixed this…) and works – just strings need to be translated….

@nickvergessen nickvergessen mentioned this pull request Sep 8, 2017
Closed
MorrisJobke
MorrisJobke approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 8a79d0c into master Sep 8, 2017
@MorrisJobke MorrisJobke deleted the share-notification-wrong-language branch September 8, 2017 17:15
@nickvergessen nickvergessen mentioned this pull request Sep 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz blizzz approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: language/translations (l10n/i18n) Localization and translation matters feature: sharing

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @MorrisJobke @blizzz