Dark hackery to not always disable CSRF for OCS controllers #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @LukasReschke and @BernhardPosselt to be potential reviewers |
Member
|
your future self would appreciate some explanation around the dark hackery 😄 |
rullzer
force-pushed
the
ocs_controller_csrf
branch
from
df60e2d to
f7f5216
Compare
Member
|
That will do 👍 |
Member
|
👍 |
MorrisJobke
added
4. to release
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
Dark hackery to not always disable CSRF for OCS controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LukasReschke as discussed.