Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 29, 2016

There was a wrong attribute causing an error in the javascript console with chrome, introduced with #627

Error: attribute preserveAspectRatio: Unrecognized enumerated value, "true".

While "true" worked, this PR uses the correct values.

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jul 29, 2016
@mention-bot
Copy link

@juliushaertl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @Henni and @LukasReschke to be potential reviewers

@jancborchardt
Copy link
Member

Looks good! 👍

@MariusBluem
Copy link
Member

MariusBluem commented Jul 30, 2016

LGTM

@MariusBluem MariusBluem merged commit 3b386af into master Jul 30, 2016
@MariusBluem MariusBluem deleted the white-app-menu-fix branch July 30, 2016 07:11
@MariusBluem
Copy link
Member

Backport does already include this fix 😅

@karlitschek
Copy link
Member

please backport

GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
Fix wrong preserveAspectRatio at app menu icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants