Skip to content

Show apps with available updates first #6740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jancborchardt merged 1 commit into from
Oct 4, 2017
Merged

Show apps with available updates first #6740

jancborchardt merged 1 commit into from
Oct 4, 2017

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 3, 2017

fix for #1236

The order is:

  • Enabled with Updates
  • Enabled without Updates
  • Disabled with Updates
  • Disabled without Updates

Inside those they are sorted alphabetically

bildschirmfoto vom 2017-10-03 15-05-03

@juliusknorr
App management: add update availability to sorting
5c34b2d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov
Copy link

codecov bot commented Oct 3, 2017 •
edited
Loading

Codecov Report

Merging #6740 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #6740      +/-   ##
============================================
- Coverage     53.01%   53.01%   -0.01%     
  Complexity    22606    22606              
============================================
  Files          1422     1422              
  Lines         87961    87963       +2     
  Branches       1341     1343       +2     
============================================
+ Hits          46632    46633       +1     
- Misses        41329    41330       +1
Impacted Files Coverage Δ Complexity Δ
settings/js/apps.js 24.4% <66.66%> (+0.1%) 0 <0> (ø) ⬇️

@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 3, 2017
LukasReschke
LukasReschke approved these changes Oct 3, 2017
View reviewed changes
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :)

@jancborchardt jancborchardt mentioned this pull request Oct 4, 2017
Merged
jancborchardt
jancborchardt approved these changes Oct 4, 2017
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! :)

@jancborchardt jancborchardt merged commit 5412c23 into master Oct 4, 2017
@jancborchardt jancborchardt deleted the apps-management-sorting-updates branch October 4, 2017 13:23
@juliusknorr juliusknorr mentioned this pull request Oct 10, 2017
Closed
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Oct 23, 2017
@boldt boldt mentioned this pull request Mar 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@eppfel eppfel Awaiting requested review from eppfel

@kcskou kcskou Awaiting requested review from kcskou

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: apps management

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr @LukasReschke @jancborchardt @MorrisJobke