-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Added additional methods for removal of sensitive info #6977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MorrisJobke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍
|
@Fiech Could I ask you to add the sign-off message to this commit (then our CI also succeeds): See https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work for the why. This should be possible by doing this: Thanks for your contribution |
Signed-off-by: Johannes Schlichenmaier <johannes@schlichenmaier.info>
Codecov Report
@@ Coverage Diff @@
## master #6977 +/- ##
=========================================
Coverage 52.82% 52.82%
Complexity 22802 22802
=========================================
Files 1442 1442
Lines 88562 88562
Branches 1349 1349
=========================================
Hits 46782 46782
Misses 41780 41780
|
|
Hey, just signed off my commit. Awesome, that everything is triggered automatically! |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
Added some unit tests in #6981 Thanks! |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
As per #6576
I'm unable to recreate the issue with the current server code, but the changes do not break the installation.
Edit by @MorrisJobke: closes #6576