SCSS cacher: use realpath on path #7060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, if the server root includes a symlink, the calculated webDir will be incorrect and CSS will break. Fix nextcloud#6028 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Member
Author
|
Would also very much like this backported to v12. |
Member
Author
|
Note that I'd love to cover this in a test if anyone could give me pointers. |
Member
Author
|
Actually, #7061 is probably better. Closing in favor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6028 more completely by using realpath in the cacher as well. Otherwise, if the server root includes a symlink, the calculated webDir will be incorrect and CSS will break.