If there is no internet connection don't try to contact appstore #7121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
3. to review
rullzer
requested review from
LukasReschke,
MorrisJobke,
blizzz and
nickvergessen
ChristophWurst
approved these changes
Nov 10, 2017
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good. In case there is a unit test for this I assume it fo fail, but let's see :)
Member
|
@rullzer The unit tests fail :/ |
skjnldsv
approved these changes
Nov 13, 2017
Fixes #7119 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@
## master #7121 +/- ##
============================================
- Coverage 50.84% 50.84% -0.01%
- Complexity 24545 24546 +1
============================================
Files 1585 1585
Lines 93796 93797 +1
Branches 1354 1354
============================================
- Hits 47689 47688 -1
- Misses 46107 46109 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7119
If your instance has no internet connection it makes no sense to try to contact the appstore.