Unlock files even if an exception occurs (stable12) #7144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristof Hamann <korelstar@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## stable12 #7144 +/- ##
==============================================
+ Coverage 53.76% 53.76% +<.01%
- Complexity 22587 22588 +1
==============================================
Files 1384 1384
Lines 86660 86663 +3
Branches 1329 1329
==============================================
+ Hits 46591 46595 +4
+ Misses 40069 40068 -1
|
Member
Author
|
Can we put this into 12.0.4? |
MorrisJobke
requested review from
icewind1991,
nickvergessen,
rullzer and
schiessle
rullzer
approved these changes
Nov 27, 2017
MorrisJobke
added
4. to release
Member
|
Let's wait for this merge until 12.0.4 is out |
LukasReschke
previously requested changes
Nov 27, 2017
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
Blocking with "Request changes" so it doesn't accidentally get merged :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7014 for stable12.