Make close icon fill more space

[pixelipo]

While working on cleaning up @nextcloud/gallery iconset, I noticed that the .icon-close SVG is disproportionately smaller. It turns out it had a lot more empty space in SVG than other icons. This is only visible when that icon is placed inline with another icon, as is the case in the gallery app.

EDIT: outdated screenshots; look at next comment
Old close.svg had more than 3px margin within SVG; after this PR, it will have 1px. Here's a before:

and after:

Please notice that in the searchbox, icon gets bigger. @nextcloud/designers is this OK? If not, let me know so I can add:
background-size: 12px;
in styles.scss (line 202)

P.S. I think in the sidebar, this icon should be as large as it is in this PR, because it doesn't make sense for the most-clicked icon to be smaller than purely visual ones.

[pixelipo]

Sorry, I think I went overboard with the initial commit; I've pushed a smaller version version, here's a new before/after:

[codecov]

Codecov Report

Merging #7239 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7239   +/-   ##
=========================================
  Coverage     50.84%   50.84%           
  Complexity    24548    24548           
=========================================
  Files          1585     1585           
  Lines         93804    93804           
  Branches       1354     1354           
=========================================
  Hits          47698    47698           
  Misses        46106    46106

[MorrisJobke]

I like it 👍

[jancborchardt]

Good catch! :)

[skjnldsv]

👍