Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Nov 23, 2017

Backport of #7211

the contacts popovermenu is also present and is being replaces, ending
up in two permission popupmenus with checkboxes duplicating the id,
breaking further permission changes.

plus, fixing a selector

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfection

@codecov
Copy link

codecov bot commented Nov 23, 2017

Codecov Report

Merging #7259 into stable12 will increase coverage by <.01%.
The diff coverage is 33.33%.

@@              Coverage Diff               @@
##             stable12    #7259      +/-   ##
==============================================
+ Coverage       53.79%   53.79%   +<.01%     
  Complexity      22590    22590              
==============================================
  Files            1384     1384              
  Lines           86666    86666              
  Branches         1329     1329              
==============================================
+ Hits            46620    46624       +4     
+ Misses          40046    40042       -4
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialogshareelistview.js 44.91% <33.33%> (ø) 0 <0> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Server.php 84.68% <0%> (-0.13%) 121% <0%> (ø)
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 4a4cf26 into stable12 Nov 23, 2017
@MorrisJobke MorrisJobke deleted the 7211-stable12 branch November 23, 2017 12:00
@MorrisJobke MorrisJobke mentioned this pull request Nov 23, 2017
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants