Fix loading icon position in the app menu #7271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
MorrisJobke,
jancborchardt,
pixelipo and
skjnldsv
Codecov Report
@@ Coverage Diff @@
## master #7271 +/- ##
=========================================
Coverage 50.86% 50.86%
Complexity 24550 24550
=========================================
Files 1585 1585
Lines 93811 93811
Branches 1354 1354
=========================================
Hits 47717 47717
Misses 46094 46094 |
MorrisJobke
approved these changes
Nov 24, 2017
LukasReschke
approved these changes
Nov 24, 2017
Member
|
@juliushaertl can you prepare the backport? |
Member
Author
|
Sure. Backport at #7457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loading icon in the app menu is a bit out of place.
Before:
After: