Skip to content

Set autocomplete on share password input #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Dec 12, 2017
Merged

Set autocomplete on share password input #7461

MorrisJobke merged 1 commit into from
Dec 12, 2017

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Dec 12, 2017

@rullzer
Set autocomplete on share password input
4577247 
Fixes #6821

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 13 milestone Dec 12, 2017
ChristophWurst
ChristophWurst approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 12, 2017
@codecov
Copy link

codecov bot commented Dec 12, 2017 •
edited
Loading

Codecov Report

Merging #7461 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7461   +/-   ##
=========================================
  Coverage     51.11%   51.11%           
  Complexity    24900    24900           
=========================================
  Files          1601     1601           
  Lines         94772    94772           
  Branches       1367     1367           
=========================================
  Hits          48438    48438           
  Misses        46334    46334
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialoglinkshareview.js 59.21% <ø> (ø) 0 <0> (ø) ⬇️
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
lib/private/Server.php 81.62% <0%> (+0.11%) 133% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 7ad746a into master Dec 12, 2017
@MorrisJobke MorrisJobke deleted the fix_6821 branch December 12, 2017 11:32
This was referenced Dec 12, 2017
Merged
Closed
@skjnldsv skjnldsv mentioned this pull request May 19, 2018
Closed
@MorrisJobke MorrisJobke mentioned this pull request Jun 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@schiessle schiessle Awaiting requested review from schiessle

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: sharing

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer @ChristophWurst @blizzz @MorrisJobke