Skip to content

Fixed redirection after password reset #7651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lal12 wants to merge 1 commit into from
Closed

Fixed redirection after password reset #7651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/js/lostpassword.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ OC.Lostpassword = {
var resetErrorMsg;
if (result && result.status === 'success'){
$.post(
OC.webroot + '/',
OC.webroot + '/ocs/v1.php',
Copy link
Member

@rullzer rullzer Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmm posting to that endpoint makes no sense... why do we actually do that? to trigger the login or what?

Copy link
Contributor Author

@lal12 lal12 Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about that too. I just assumed it is to check whether the password changed. But usually this error should be reported by the response from the previous request. But I am not familiar with the next loud code.

Copy link
Contributor Author

@lal12 lal12 Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I remove this request instead?

Copy link
Member

@rullzer rullzer Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Year try it and see if it still works :)

Copy link
Contributor Author

@lal12 lal12 Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look here: #7691,
I accidentily deleted my fork...

Copy link
Member

@rullzer rullzer Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lets close this then

{
user : window.location.href.split('/').pop(),
password : $('#password').val()
Expand Down