Also cache WOFF, SVG and GIF

[LukasReschke]

No description provided.

[MorrisJobke]

👍

[MorrisJobke]

@josh4trunks Is it fine to update this NGINX config line:

  # Adding the cache control header for js and css files
  # Make sure it is BELOW the PHP block
  location ~* \.(?:css|js)$ {

[josh4trunks]

looks good to me.
those extension types should be removed from the static location at the end (of the nginx config example)
location ~* \.(?:svg|gif|png|html|ttf|woff|ico|jpg|jpeg)$ {

[rullzer]

👍

[MorrisJobke]

looks good to me.
those extension types should be removed from the static location at the end (of the nginx config example)

There is only one endpoint: preview.png that needs to be executed by PHP. Or am I wrong? cc @rullzer

[josh4trunks]

@MorrisJobke that's why this block has to be below the PHP block, since regex blocks are matched first.

Actually, are we doing this? If so I don't understand how we know to pass preview.png to PHP based on the documented config.

[MorrisJobke]

Actually, are we doing this? If so I don't understand how we know to pass preview.png to PHP based on the documented config.

These are the routes:

server/core/routes.php

Lines 112 to 115 in 8c7d7d7

	$this->create('core_ajax_preview', '/core/preview')
	->actionInclude('core/ajax/preview.php');
	$this->create('core_ajax_preview', '/core/preview.png')
	->actionInclude('core/ajax/preview.php');

@LukasReschke Where are the rules for excluding this in the apache config?

[josh4trunks]

ahh, yes this is handled correctly with the current nginx config. I was correct in my earlier statement, as long as the static location block is last. the nginx config will only match locations to actual files so since preview.png doesn't exist the request is given to index.php