Max preview size to 4096x4096 #7731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
MorrisJobke,
danxuliu,
jancborchardt and
nickvergessen
MorrisJobke
approved these changes
Jan 8, 2018
With HiDPI screens. And even normal HD screens you want more detail from your pictures. Or the ability to somewhat zoom on you previews. For this we need somewhat larger previews. Moving the default to 4096x4096 is a step up. Users that want the old behavior can still set the values in config.php Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
preview_size_inc
branch
from
db2ad96 to
e2352cc
Compare
Member
Author
|
rebased to fix conflict |
Codecov Report
@@ Coverage Diff @@
## master #7731 +/- ##
=========================================
Coverage 51.18% 51.18%
Complexity 24948 24948
=========================================
Files 1605 1605
Lines 94922 94922
Branches 1376 1376
=========================================
Hits 48584 48584
Misses 46338 46338
|
jancborchardt
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With HiDPI screens. And even normal HD screens you want more detail from
your pictures. Or the ability to somewhat zoom on you previews. For this
we need somewhat larger previews.
Moving the default to 4096x4096 is a step up. Users that want the old
behavior can still set the values in config.php
We should mention this in the release notes... @jospoortvliet