Skip to content

Make the ITimeFactory strict + return types #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Jan 15, 2018
Merged

Make the ITimeFactory strict + return types #7838

rullzer merged 1 commit into from
Jan 15, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jan 13, 2018

No description provided.

@rullzer rullzer added enhancement 3. to review Waiting for reviews labels Jan 13, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone Jan 13, 2018
@codecov
Copy link

codecov bot commented Jan 13, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c0c4263). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #7838   +/-   ##
=========================================
  Coverage          ?   51.21%           
  Complexity        ?    24956           
=========================================
  Files             ?     1607           
  Lines             ?    95046           
  Branches          ?     1376           
=========================================
  Hits              ?    48674           
  Misses            ?    46372           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
lib/private/AppFramework/Utility/TimeFactory.php 100% <100%> (ø) 1 <1> (?)

@MorrisJobke MorrisJobke mentioned this pull request Jan 13, 2018
Closed
ChristophWurst
ChristophWurst approved these changes Jan 13, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rullzer
Make the ITimeFactory strict + return types
7ffd62b 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the timefactory_strict branch from 34bfd6c to 7ffd62b Compare January 14, 2018 20:55
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 15, 2018
@rullzer rullzer merged commit d44de92 into master Jan 15, 2018
@rullzer rullzer deleted the timefactory_strict branch January 15, 2018 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @ChristophWurst @juliusknorr