Admin setting PHP and SMTP casing #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @LukasReschke and @jancborchardt to be potential reviewers |
Member
|
Tested and works 👍 |
Member
|
LGTM |
Member
|
Backport at #804 |
| } | ||
| if ($_['mail_smtpmode'] == 'qmail') { | ||
| $mail_smtpmode[] = 'qmail'; | ||
| $mail_smtpmode[] = ['qmail', 'qmail']; |
Member
There was a problem hiding this comment.
What’s this here … aren’t the two values the same? ;)
Member
There was a problem hiding this comment.
Yes, but one is the internal value and the other the shown value ;)
Member
Author
There was a problem hiding this comment.
@jancborchardt indeed one is internal and one is what we show. So internally we still use 'php' and 'smtp'. Since I did not want to change all the logic add repair steps and the likes ;)
Member
There was a problem hiding this comment.
Ah, thanks for the info :)
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
Admin setting PHP and SMTP casing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #735
CC: @LukasReschke @MorrisJobke @schiessle @nickvergessen @icewind1991