Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jan 13, 2018

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented Jan 13, 2018

Codecov Report

Merging #7840 into master will increase coverage by <.01%.
The diff coverage is 44.44%.

@@             Coverage Diff              @@
##             master    #7840      +/-   ##
============================================
+ Coverage      51.2%   51.21%   +<.01%     
+ Complexity    24956    24946      -10     
============================================
  Files          1607     1606       -1     
  Lines         95046    95019      -27     
  Branches       1376     1376              
============================================
- Hits          48673    48665       -8     
+ Misses        46373    46354      -19
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Scanner.php 82.55% <ø> (ø) 115 <0> (ø) ⬇️
lib/private/App/CodeChecker/DeprecationCheck.php 10.2% <ø> (+0.1%) 5 <0> (ø) ⬇️
apps/user_ldap/appinfo/install.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/legacy/util.php 58.34% <0%> (ø) 230 <0> (ø) ⬇️
apps/user_ldap/lib/Configuration.php 42.02% <100%> (ø) 87 <0> (ø) ⬇️
apps/user_ldap/lib/Jobs/UpdateGroups.php 3.41% <100%> (ø) 21 <0> (ø) ⬇️
lib/private/Share/Share.php 63.37% <50%> (ø) 421 <0> (ø) ⬇️
lib/private/Server.php 81.43% <0%> (-0.12%) 134% <0%> (ø)
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

@MorrisJobke
Copy link
Member

CI failure is "only" the samba race condition.

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 14, 2018
@rullzer rullzer merged commit 419de27 into master Jan 14, 2018
@rullzer rullzer deleted the dep_config branch January 14, 2018 21:21
tabp0le added a commit to tabp0le/rainloop-nextcloud that referenced this pull request Sep 12, 2018
tabp0le added a commit to tabp0le/rainloop-nextcloud that referenced this pull request Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants