do not catch and ignore ServerNotAvailable in the wrong spot #8069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
might cause the user to be unavailable (race condition). Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@
## master #8069 +/- ##
============================================
+ Coverage 51.7% 51.71% +<.01%
- Complexity 25456 25457 +1
============================================
Files 1599 1599
Lines 95275 95277 +2
Branches 1376 1376
============================================
+ Hits 49266 49268 +2
Misses 46009 46009
|
MorrisJobke
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not aware this ever happened, but it does not need to.
Scenario: user exists check: when the LDAP server goes offline in the right moment, the user will be set as non-existing (for as long as cache lives), because any Exceptions was caught and ignored. We make sure to pass on ServerNotAvailable now.