Skip to content

actually return stream from swift #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Feb 8, 2018
Merged

actually return stream from swift #8233

rullzer merged 1 commit into from
Feb 8, 2018

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Feb 7, 2018

🙈

@icewind1991
actually return stream from swift
fd09c06 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 7, 2018
@icewind1991 icewind1991 added this to the Nextcloud 14 milestone Feb 7, 2018
@codecov
Copy link

codecov bot commented Feb 7, 2018 •
edited
Loading

Codecov Report

Merging #8233 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #8233      +/-   ##
============================================
+ Coverage     51.73%   51.73%   +<.01%     
  Complexity    25366    25366              
============================================
  Files          1599     1599              
  Lines         95064    95064              
  Branches       1376     1376              
============================================
+ Hits          49180    49186       +6     
+ Misses        45884    45878       -6
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/Swift.php 0% <0%> (ø) 42 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.7% <0%> (+0.24%) 136% <0%> (ø) ⬇️
core/js/js.js 66.29% <0%> (+0.55%) 0% <0%> (ø) ⬇️

rullzer
rullzer approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woeps

@rullzer
Copy link
Member

rullzer commented Feb 7, 2018

And backport please ;-)

@rullzer rullzer mentioned this pull request Feb 7, 2018
Closed
This was referenced Feb 8, 2018
Merged
Merged
@rullzer rullzer merged commit b939383 into master Feb 8, 2018
@rullzer rullzer deleted the swift-return-stream branch February 8, 2018 07:15
@juliusknorr juliusknorr mentioned this pull request Feb 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @rullzer @skjnldsv