[12] Fix deleting folders when using s3 external storage #8262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer. |
MorrisJobke
approved these changes
Feb 8, 2018
rullzer
approved these changes
Feb 12, 2018
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
force-pushed
the
s3-folder-delete-12
branch
from
3909582 to
4c903e6
Compare
Codecov Report
@@ Coverage Diff @@
## stable12 #8262 +/- ##
==============================================
- Coverage 53.84% 53.84% -0.01%
- Complexity 22754 22755 +1
==============================================
Files 1386 1386
Lines 87126 87129 +3
Branches 1331 1331
==============================================
- Hits 46915 46914 -1
- Misses 40211 40215 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8100