Make SMB module more fault-tolerant #8285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore unavailable files when fetching the share's mtime or reading directory listings. This can happen on servers using a distributed file system (DFS) with unavailable destinations, for example when the remote server is offline. Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
icewind1991
approved these changes
Feb 9, 2018
Author
|
@icewind1991 Do you see why the integration test has failed? I cannot see a reason for this, and the stack trace seems to have nothing to do with SMB... can I somehow reproduce this test locally? |
Member
|
It's unrelated |
rullzer
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore unavailable files when fetching the share's mtime
or reading directory listings. This can happen on servers using a
distributed file system (DFS) with unavailable destinations, for example
when the remote server is offline.