Make acceptance tests for comments more consistent with the others #8382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The locators are moved above the step definitions for consistency with other context files; besides that I made some minor adjustments for consistency too in the locator descriptions and identation, and moved the locators for ".newCommentRow" descendants together. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Depending on the previous steps the new comment field may be already shown or not when the step to create a new comment is executed. Therefore, the timeout was increased from 2 to the "standard" 10 seconds used in other tests. If the new comment field was found there is no need to use a timeout when looking for the new comment button; it is either there or not, it will not appear after some time. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Instead of checking that the list contains one comment it is now checked that a comment with certain message is visible. This makes the step (and the locator) more reusable in future tests and also simplifies the code. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
MorrisJobke
approved these changes
Feb 16, 2018
Member
|
Tests only -> merge |
MorrisJobke
deleted the
make-acceptance-tests-for-comments-more-consistent-with-the-others
branch
Member
|
@danxuliu Please do the backport - that's fine |
Member
Author
|
@MorrisJobke When doing the backport I noticed that I am not well versed in the fine art of copy-pasting; #8396 fixes that in master; the typo is already fixed in the backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the acceptance tests for comments to Drone and also changes some of its code to make it more consistent with the other acceptance tests (how the fields are sorted in the context file, adjustments in the timeouts, and a change in a step to make it more reusable and also simplify its code).
As it does not interfere with Nextcloud 13 code but improves the test coverage I would backport this to stable13 (or, if not all, at least the commit that adds the acceptance tests for comments to Drone, as they are already in stable13 but unused).