Add indeterminate state to share permission checkbox #8390
Conversation
…extcloud#8371 Signed-off-by: Maximilian Wende <dasisdormax@secure.mailbox.org>
Also, the checkbox is updated to the correct state while a permission change is in progress. should fix issue nextcloud#8371 Signed-off-by: Maximilian Wende <dasisdormax@secure.mailbox.org>
MorrisJobke
requested review from
ChristophWurst,
danxuliu,
juliusknorr,
pixelipo and
skjnldsv
|
The JSUnit tests fail: Could you have a look at https://drone.nextcloud.com/nextcloud/server/4940/216 (roughly line 900+)? |
Signed-off-by: Maximilian Wende <dasisdormax@mailbox.org>
Codecov Report
@@ Coverage Diff @@
## master #8390 +/- ##
===========================================
- Coverage 51.71% 51.3% -0.42%
Complexity 25404 25404
===========================================
Files 1600 1535 -65
Lines 95135 87332 -7803
Branches 1377 0 -1377
===========================================
- Hits 49198 44803 -4395
+ Misses 45937 42529 -3408 |
|
@MorrisJobke it seems that my change in the render function revealed a bug we haven't found before (slashes in the sharee's federation URL weren't escaped). Fixed that and updated the test for the new desired behaviour. Let's see if there's more ... |
|
@dasisdormax Thanks for the pull request. That is a really nice improvement. 👍 |
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code change looks good and works nicely 👍
|
Swift CI failure is known -> from CI point of view it's good to merge. @ChristophWurst @skjnldsv @danxuliu @rullzer Mind to review this one here? |
|
Hey @dasisdormax we would like to invite you to the IRC channel #nextcloud-dev on freenode. Maybe also have a look at the other "good first issues": https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
3 participants
This PR adds the 'indeterminate' checkbox state to the general "can edit" checkbox if some, but not all of the 'create', 'update', and 'delete' prermissions are given for that share. See issue #8371