Fix hiding and event propagation issues with the user management popover #8416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
nickvergessen
approved these changes
Feb 20, 2018
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Works, need backport to 13.0.1
blizzz
approved these changes
Feb 22, 2018
Member
|
@juliushaertl do you do the backport? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues from #8401 as well as the popovermenu not being closed when clicking the more icon again.
Removing the additional .menu and .bubble classes takes care that event propagation will not be stopped by the menu handling from core/js/js.js, since the user management has implemented its own code to show/hide popovers.
@nickvergessen The event listener from the impersonate app will work without change after that PR. Anyway I would recommend to use
$userListBody.on('click', '.toggleUserActions', function() {})which will work with and without the patch and is basically the same approach that is used for all the other actions in the user settings.