Skip to content

[stable12] group existence check works without attribute (like with users) #8850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Mar 16, 2018
Merged

[stable12] group existence check works without attribute (like with users) #8850

rullzer merged 1 commit into from
Mar 16, 2018

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Mar 16, 2018

backport of #8835

@blizzz
existence check works without attribute (like with users)
c0ee3cd 
cn is not necessarily given everywhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 12.0.7 milestone Mar 16, 2018
@blizzz blizzz requested review from MorrisJobke and rullzer March 16, 2018 09:32
@codecov
Copy link

codecov bot commented Mar 16, 2018 •
edited
Loading

Codecov Report

Merging #8850 into stable12 will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             stable12    #8850   +/-   ##
===========================================
  Coverage       53.91%   53.91%           
  Complexity      22779    22779           
===========================================
  Files            1387     1387           
  Lines           87285    87285           
  Branches         1331     1331           
===========================================
  Hits            47062    47062           
  Misses          40223    40223
Impacted Files Coverage Δ Complexity Δ
apps/user_ldap/lib/Access.php 19.25% <0%> (ø) 308 <0> (ø) ⬇️

@rullzer rullzer merged commit 0c501a8 into stable12 Mar 16, 2018
@rullzer rullzer deleted the backport/8835/stable12 branch March 16, 2018 13:25
@MorrisJobke MorrisJobke mentioned this pull request Apr 18, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: ldap

Projects

None yet

Milestone

Nextcloud 12.0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz @rullzer @MorrisJobke