Skip to content

Remove deprecated and unused method OCP\User::getDisplayNames #8919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Mar 21, 2018
Merged

Remove deprecated and unused method OCP\User::getDisplayNames #8919

MorrisJobke merged 1 commit into from
Mar 21, 2018

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 21, 2018

Ref #7827

@MorrisJobke
Remove deprecated and unused method OCP\User::getDisplayNames
591d84f 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Mar 21, 2018
@MorrisJobke MorrisJobke mentioned this pull request Mar 21, 2018
Closed
ChristophWurst
ChristophWurst approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 21, 2018
@codecov
Copy link

codecov bot commented Mar 21, 2018 •
edited
Loading

Codecov Report

Merging #8919 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #8919      +/-   ##
===========================================
+ Coverage     51.89%   51.9%   +<.01%     
+ Complexity    25278   25277       -1     
===========================================
  Files          1604    1604              
  Lines         94798   94796       -2     
  Branches       1377    1377              
===========================================
+ Hits          49193   49201       +8     
+ Misses        45605   45595      -10
Impacted Files Coverage Δ Complexity Δ
lib/public/User.php 42.85% <ø> (+5.35%) 7 <0> (-1) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.46% <0%> (-0.25%) 136% <0%> (ø)
core/js/js.js 65.85% <0%> (+0.55%) 0% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️
lib/private/Files/ObjectStore/SwiftFactory.php 55% <0%> (+4%) 37% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 24292be into master Mar 21, 2018
@MorrisJobke MorrisJobke deleted the remove-deprecated-method-of-ocp-user branch March 21, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke @icewind1991 @ChristophWurst @skjnldsv