Skip to content

Strict 2FA #8981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 2 commits into from
Mar 26, 2018
Merged

Strict 2FA #8981

rullzer merged 2 commits into from
Mar 26, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Mar 26, 2018 •
edited
Loading

@rullzer rullzer added this to the Nextcloud 14 milestone Mar 26, 2018
@rullzer rullzer requested a review from ChristophWurst March 26, 2018 09:23
ChristophWurst
ChristophWurst requested changes Mar 26, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😍

lib/public/Authentication/TwoFactorAuth/IProvider.php Outdated
* @return string
*/
public function getDescription();
public function getDescription(): string ;
Copy link
Member

@ChristophWurst ChristophWurst Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace 😉

Copy link
Member Author

@rullzer rullzer Mar 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where... 😉

@ChristophWurst ChristophWurst self-assigned this Mar 26, 2018
rullzer added 2 commits March 26, 2018 11:31
@rullzer
Strict 2FA
24b1238 
* make OCP\Authentication\TwoFactorAuth strict
* scalar types
* return types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Make 2FA backupcodes strict
b52c935 
* and follow the interface again

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
ChristophWurst
ChristophWurst approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 26, 2018
@rullzer rullzer merged commit 4edcaa9 into master Mar 26, 2018
@rullzer rullzer deleted the strict_2fa branch March 26, 2018 19:40
@MorrisJobke MorrisJobke mentioned this pull request Mar 26, 2018
Closed
This was referenced Mar 26, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @nickvergessen @ChristophWurst