Skip to content

Deprecate theme sync clients #8994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 1 commit into from
Mar 28, 2018
+9 −38
Merged

Deprecate theme sync clients #8994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions config/config.sample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,15 +782,17 @@
* Defaults to
* * Desktop client: ``https://nextcloud.com/install/#install-clients``
* * Android client: ``https://play.google.com/store/apps/details?id=com.nextcloud.client``
* * iOS client : ``https://itunes.apple.com/us/app/nextcloud/id1125420102?mt=8``
* * iOS client: ``https://itunes.apple.com/us/app/nextcloud/id1125420102?mt=8``
* *iOS client app id: ``1125420102``
*/
'customclient_desktop' =>
'https://nextcloud.com/install/#install-clients',
'customclient_android' =>
'https://play.google.com/store/apps/details?id=com.nextcloud.client',
'customclient_ios' =>
'https://itunes.apple.com/us/app/nextcloud/id1125420102?mt=8',

'customclient_ios_appid' =>
'1125420102',
/**
* Apps
*
Expand Down
9 changes: 5 additions & 4 deletions lib/private/legacy/defaults.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,16 @@ class OC_Defaults {

public function __construct() {
$this->l = \OC::$server->getL10N('lib');
$config = \OC::$server->getConfig();

$this->defaultEntity = 'Nextcloud'; /* e.g. company name, used for footers and copyright notices */
$this->defaultName = 'Nextcloud'; /* short name, used when referring to the software */
$this->defaultTitle = 'Nextcloud'; /* can be a longer name, for titles */
$this->defaultBaseUrl = 'https://nextcloud.com';
$this->defaultSyncClientUrl = 'https://nextcloud.com/install/#install-clients';
$this->defaultiOSClientUrl = 'https://geo.itunes.apple.com/us/app/nextcloud/id1125420102?mt=8';
$this->defaultiTunesAppId = '1125420102';
$this->defaultAndroidClientUrl = 'https://play.google.com/store/apps/details?id=com.nextcloud.client';
$this->defaultSyncClientUrl = $config->getSystemValue('customclient_desktop', 'https://nextcloud.com/install/#install-clients');
$this->defaultiOSClientUrl = $config->getSystemValue('customclient_ios', 'https://geo.itunes.apple.com/us/app/nextcloud/id1125420102?mt=8');
$this->defaultiTunesAppId = $config->getSystemValue('customclient_ios_appid', '1125420102');
$this->defaultAndroidClientUrl = $config->getSystemValue('customclient_android', 'https://play.google.com/store/apps/details?id=com.nextcloud.client');
$this->defaultDocBaseUrl = 'https://docs.nextcloud.com';
$this->defaultDocVersion = '14'; // used to generate doc links
$this->defaultSlogan = $this->l->t('a safe home for all your data');
Expand Down
32 changes: 0 additions & 32 deletions themes/example/defaults.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,38 +28,6 @@ public function getBaseUrl() {
return 'https://nextcloud.com';
}

/**
* Returns the URL where the sync clients are listed
* @return string URL
*/
public function getSyncClientUrl() {
return 'https://nextcloud.com/install/#install-clients';
}

/**
* Returns the URL to the App Store for the iOS Client
* @return string URL
*/
public function getiOSClientUrl() {
return 'https://geo.itunes.apple.com/us/app/nextcloud/id1125420102?mt=8';
}

/**
* Returns the AppId for the App Store for the iOS Client
* @return string AppId
*/
public function getiTunesAppId() {
return '1125420102';
}

/**
* Returns the URL to Google Play for the Android Client
* @return string URL
*/
public function getAndroidClientUrl() {
return 'https://play.google.com/store/apps/details?id=com.nextcloud.client';
}

/**
* Returns the documentation URL
* @return string URL
Expand Down