Skip to content

Conversation

@brandonkirsch
Copy link

Microsoft OneNote WebDAV Client requires some special handling on the server side that is enabled by User Agent detection. This PR updates the User Agent detection string to be compatible with all versions of OneNote.

@brandonkirsch
Copy link
Author

Current version of One Note has User Agent string:

OneNote/16.0.8431.2110 (Windows/6.1; Desktop WOW64; en-US; Desktop app; LENOVO/20AQ006HUS)

@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: dav labels Mar 27, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Mar 27, 2018
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pfff I hate this magic... but yeah fair enough 🙈

@nickvergessen
Copy link
Member

No microsoft anymore?

@brandonkirsch
Copy link
Author

No, over the years they have removed "Microsoft", "Office" and the release year from User Agent. Thanks for reviewing the patch it will be easier for me to stay up to date.

Copy link
Member

@schiessle schiessle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea about OneNote, but it sounds reasonable

@MorrisJobke MorrisJobke merged commit bd8352d into nextcloud:master Apr 3, 2018
@MorrisJobke
Copy link
Member

@nickvergessen @rullzer @schiessle I guess we should backport this to stable13 at least, right?

@schiessle
Copy link
Member

@MorrisJobke yes, I think it would make sense... @brandonkirsch do you want to create a PR for the backport angainst stable13? This would be awesome!

@nickvergessen
Copy link
Member

yes

@MorrisJobke
Copy link
Member

Backported in #9236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants