-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix webdav support for OneNote clients #8996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Current version of One Note has User Agent string: OneNote/16.0.8431.2110 (Windows/6.1; Desktop WOW64; en-US; Desktop app; LENOVO/20AQ006HUS) |
rullzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pfff I hate this magic... but yeah fair enough 🙈
|
No microsoft anymore? |
|
No, over the years they have removed "Microsoft", "Office" and the release year from User Agent. Thanks for reviewing the patch it will be easier for me to stay up to date. |
schiessle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea about OneNote, but it sounds reasonable
|
@nickvergessen @rullzer @schiessle I guess we should backport this to stable13 at least, right? |
|
@MorrisJobke yes, I think it would make sense... @brandonkirsch do you want to create a PR for the backport angainst stable13? This would be awesome! |
|
yes |
|
Backported in #9236 |
Microsoft OneNote WebDAV Client requires some special handling on the server side that is enabled by User Agent detection. This PR updates the User Agent detection string to be compatible with all versions of OneNote.