[stable12] Use multibyte substring #9235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7661 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
requested review from
ChristophWurst,
icewind1991,
juliusknorr,
nickvergessen and
rullzer
Codecov Report
@@ Coverage Diff @@
## stable12 #9235 +/- ##
==============================================
- Coverage 53.91% 53.91% -0.01%
Complexity 22780 22780
==============================================
Files 1387 1387
Lines 87286 87286
Branches 1331 1331
==============================================
- Hits 47063 47062 -1
- Misses 40223 40224 +1
|
juliusknorr
approved these changes
Apr 18, 2018
rullzer
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7661
Backport of #9097