Move log constants to ILogger #9308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
MorrisJobke
requested review from
blizzz,
icewind1991,
nickvergessen and
rullzer
7 tasks
rullzer
approved these changes
Apr 26, 2018
Codecov Report
@@ Coverage Diff @@
## master #9308 +/- ##
============================================
+ Coverage 51.92% 51.93% +<.01%
Complexity 25388 25388
============================================
Files 1608 1608
Lines 95429 95440 +11
Branches 1394 1394
============================================
+ Hits 49555 49564 +9
- Misses 45874 45876 +2
|
Member
Author
|
👍 from me as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9166 to get the PR more focused on it's purpose