Skip to content

[stable13] Fix ellipsis in filename column #9344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 2 commits into from
May 1, 2018
Merged

[stable13] Fix ellipsis in filename column #9344

rullzer merged 2 commits into from
May 1, 2018

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 30, 2018

backport of #9248

@nextcloud/designers

@juliusknorr
Use flex based layout inside the filename table cell
7e39215 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Add min-width to trick the table width calculation in safari
5c6084a 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug design Design, UI, UX, etc. 3. to review Waiting for reviews high labels Apr 30, 2018
@juliusknorr juliusknorr added this to the Nextcloud 13.0.3 milestone Apr 30, 2018
@juliusknorr juliusknorr mentioned this pull request Apr 30, 2018
Merged
@johnyb0y
Copy link

johnyb0y commented Apr 30, 2018

Thanks!

@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 30, 2018

JS failure seems unrelated, because this is an SCSS only change.

@skjnldsv
Copy link
Member

skjnldsv commented Apr 30, 2018

@MorrisJobke restarted to be sure :)

MorrisJobke
MorrisJobke approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@skjnldsv
Copy link
Member

skjnldsv commented Apr 30, 2018

Same error, it might be good to look at it:

PhantomJS 2.1.1 (Linux 0.0.0) DeleteHandler tests deletes first entry and reshows notification on second delete FAILED
	TypeError: undefined is not a function (evaluating 'showNotificationSpy.reset()') in settings/tests/js/users/deleteHandlerSpec.js (line 82)
	settings/tests/js/users/deleteHandlerSpec.js:82:28

@juliusknorr
Copy link
Member Author

juliusknorr commented Apr 30, 2018

@skjnldsv It seems that it is also failing on master/stable13 since the test dependency sinon has removed a deprecated method in their new release 3 days ago.

Fix is in #9348

@rullzer rullzer merged commit 6976241 into stable13 May 1, 2018
@rullzer rullzer deleted the stable13-9248 branch May 1, 2018 17:58
@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. high

Projects

None yet

Milestone

Nextcloud 13.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@juliusknorr @johnyb0y @MorrisJobke @skjnldsv @rullzer