remove unneeded locks in getCacheEntry #9387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
approved these changes
May 4, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
A lot better for an upload of a single file.
Before:
acquire shared lock on "files/github.png" on storage "home::admin"
release shared lock on "files/github.png" on storage "home::admin"
acquire shared lock on "files/github.png" on storage "home::admin"
release shared lock on "files/github.png" on storage "home::admin"
acquire shared lock on "files/github.png" on storage "home::admin"
release shared lock on "files/github.png" on storage "home::admin"
acquire shared lock on "files/github.png" on storage "home::admin"
acquire exclusive lock on "files/admin/files/github.png.upload.part" on storage "home::admin"
acquire shared lock on "files/admin" on storage "home::admin"
acquire shared lock on "files/admin/files" on storage "home::admin"
acquire shared lock on "files/github.png" on storage "home::admin"
release shared lock on "files/github.png" on storage "home::admin"
acquire shared lock on "files/github.png" on storage "home::admin"
release shared lock on "files/github.png" on storage "home::admin"
change lock on "files/github.png" to exclusive on storage "home::admin"
change lock on "files/github.png" to shared on storage "home::admin"
release exclusive lock on "files/admin/files/github.png.upload.part" on storage "home::admin"
release shared lock on "files/admin" on storage "home::admin"
release shared lock on "files/admin/files" on storage "home::admin"
release shared lock on "files/github.png" on storage "home::admin"
release shared lock on "files/github.png" on storage "home::admin"
After:
acquire shared lock on "files/github.png" on storage "home::admin"
change lock on "files/github.png" to exclusive on storage "home::admin"
change lock on "files/github.png" to shared on storage "home::admin"
release shared lock on "files/github.png" on storage "home::admin"
Member
|
@icewind1991 Could you please open a backport for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra locking there isn't needed to ensure a consistent state