Skip to content

Conversation

@MariusBluem
Copy link
Member

As discussed with @karlitschek and @schiessle 🤣

Signed-off-by: Marius Blüm marius@lineone.io

Signed-off-by: Marius Blüm <marius@lineone.io>
@MariusBluem MariusBluem added the 3. to review Waiting for reviews label May 8, 2018
@MariusBluem MariusBluem added this to the Nextcloud 14 milestone May 8, 2018
@codecov
Copy link

codecov bot commented May 8, 2018

Codecov Report

Merging #9418 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9418      +/-   ##
============================================
+ Coverage     51.61%   51.62%   +<.01%     
  Complexity    25679    25679              
============================================
  Files          1638     1638              
  Lines         96274    96272       -2     
  Branches       1393     1393              
============================================
  Hits          49696    49696              
+ Misses        46578    46576       -2
Impacted Files Coverage Δ Complexity Δ
index.php 0% <ø> (ø) 0 <0> (ø) ⬇️

@karlitschek
Copy link
Member

👍

@MorrisJobke
Copy link
Member

@karlitschek Be aware of the GitHub review feature - then I don't need to forcefully merge this, but the merge button actually gets green because of two approvals ;)

bildschirmfoto 2018-05-08 um 17 00 26

@MorrisJobke MorrisJobke merged commit 4327eea into master May 8, 2018
@MorrisJobke MorrisJobke deleted the php-message-indexphp branch May 8, 2018 15:01
@MorrisJobke
Copy link
Member

@MariusBluem Please backport to stable13

@karlitschek
Copy link
Member

@MorrisJobke Got it. Sorry :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants