[stable13] Add labels for Contacts menu and Settings #9433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thanks to @MarcoZehe Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
MorrisJobke
requested review from
ChristophWurst,
jancborchardt,
juliusknorr and
skjnldsv
jancborchardt
approved these changes
May 9, 2018
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Only on mobile since laptop in repair, so not tested. But code changes look good.
Codecov Report
@@ Coverage Diff @@
## stable13 #9433 +/- ##
==============================================
- Coverage 51.36% 51.36% -0.01%
Complexity 25051 25051
==============================================
Files 1609 1609
Lines 95342 95348 +6
Branches 1376 1376
==============================================
+ Hits 48973 48974 +1
- Misses 46369 46374 +5
|
rullzer
approved these changes
May 10, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9224