Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented May 14, 2018

Fixes #9469

When a version of a file is restored the previews are no longer valid.
Thus we should remove them so they are regenerated.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes #9469

When a version of a file is restored the previews are no longer valid.
Thus we should remove them so they are regenerated.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #9475 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #9475      +/-   ##
============================================
+ Coverage     51.71%   51.72%   +<.01%     
- Complexity    25696    25699       +3     
============================================
  Files          1640     1640              
  Lines         96337    96346       +9     
  Branches       1393     1393              
============================================
+ Hits          49823    49833      +10     
+ Misses        46514    46513       -1
Impacted Files Coverage Δ Complexity Δ
apps/files_versions/lib/Storage.php 66.32% <100%> (+0.25%) 103 <0> (ø) ⬇️
lib/private/Preview/WatcherConnector.php 91.66% <100%> (+0.75%) 5 <0> (ø) ⬇️
lib/private/Preview/Watcher.php 64.28% <40%> (-13.5%) 7 <5> (+3)
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
core/js/js.js 65.96% <0%> (+0.55%) 0% <0%> (ø) ⬇️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 0011bfb into master May 16, 2018
@MorrisJobke MorrisJobke deleted the bug/9469/delete_preview_on_version_restore branch May 16, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants