Skip to content

[stable13] allow to specify a link to a legal notice #9516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
May 22, 2018
Merged

[stable13] allow to specify a link to a legal notice #9516

MorrisJobke merged 1 commit into from
May 22, 2018

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented May 18, 2018

Backport of #9437

@blizzz
Backport of #9437
c3d2888 
allow to specify a link to a legal notice

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix undo for url-typed inputs

and minor adjustments

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Use link not address in labels for URLs

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

this file does not belong here

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 13.0.3 milestone May 18, 2018
@codecov
Copy link

codecov bot commented May 18, 2018 •
edited
Loading

Codecov Report

Merging #9516 into stable13 will decrease coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             stable13    #9516      +/-   ##
==============================================
- Coverage       51.38%   51.38%   -0.01%     
- Complexity      25052    25057       +5     
==============================================
  Files            1609     1609              
  Lines           95350    95373      +23     
  Branches         1376     1376              
==============================================
+ Hits            48999    49010      +11     
- Misses          46351    46363      +12
Impacted Files Coverage Δ Complexity Δ
apps/theming/templates/settings-admin.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/theming/lib/Settings/Admin.php 86.48% <100%> (+0.37%) 5 <0> (ø) ⬇️
apps/theming/lib/ThemingDefaults.php 92.25% <100%> (+0.46%) 49 <1> (+3) ⬆️
apps/theming/lib/Controller/ThemingController.php 73.16% <20%> (-2.03%) 45 <0> (+2)

rullzer
rullzer approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

MorrisJobke
MorrisJobke approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 5744827 into stable13 May 22, 2018
@MorrisJobke MorrisJobke deleted the backport/9437/stable13 branch May 22, 2018 14:54
@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
Merged
@giteck
Copy link

giteck commented Mar 4, 2022

This app was really needed, and is working fine, thank you!
But there is still one issue: the file with legal notice makes nextcloud to fail the integrity check. In which directory should it be placed in order to avoid this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: theming

Projects

None yet

Milestone

Nextcloud 13.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@blizzz @giteck @rullzer @MorrisJobke