Skip to content

Conversation

@remyj38
Copy link
Contributor

@remyj38 remyj38 commented May 22, 2018

During resetting user's password, the controller return the untranslated message (from basic exception) instead of the hint message (translated).

Fix nextcloud/password_policy#26

Signed-off-by: Rémy Jacquin remy@remyj.fr

Fix nextcloud/password_policy#26

Signed-off-by: Rémy Jacquin <remy@remyj.fr>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤖

@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews labels May 22, 2018
@ChristophWurst ChristophWurst added this to the Nextcloud 13.0.3 milestone May 22, 2018
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #9548 into stable13 will decrease coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             stable13    #9548      +/-   ##
==============================================
- Coverage       51.38%   51.38%   -0.01%     
- Complexity      25057    25058       +1     
==============================================
  Files            1609     1609              
  Lines           95373    95375       +2     
  Branches         1376     1376              
==============================================
- Hits            49010    49006       -4     
- Misses          46363    46369       +6
Impacted Files Coverage Δ Complexity Δ
core/Controller/LostController.php 79.35% <50%> (-0.39%) 33 <0> (+1)
core/js/js.js 65.81% <0%> (-0.56%) 0% <0%> (ø)

@MorrisJobke MorrisJobke merged commit 04ff701 into nextcloud:stable13 May 22, 2018
@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants